emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ef-themes 0afddb9147 1/3: Add source comment about need


From: ELPA Syncer
Subject: [elpa] externals/ef-themes 0afddb9147 1/3: Add source comment about needless fallback case
Date: Tue, 1 Nov 2022 21:57:53 -0400 (EDT)

branch: externals/ef-themes
commit 0afddb9147494c36995a27c77021820ea0a9ac27
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Add source comment about needless fallback case
---
 ef-themes.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ef-themes.el b/ef-themes.el
index f6552eb737..303da675d4 100644
--- a/ef-themes.el
+++ b/ef-themes.el
@@ -370,6 +370,11 @@ accordingly."
          (themes (pcase subset
                    ('dark ef-themes-dark-themes)
                    ('light ef-themes-light-themes)
+                   ;; NOTE 2022-11-02: This condition made sense when
+                   ;; the code now in `ef-themes--choose-subset' used
+                   ;; `completing-read'.  With `read-multiple-choice'
+                   ;; we never meet this condition, as far as I can
+                   ;; tell.  But it does no harm to keep it here.
                    (_ (ef-themes--list-known-themes)))))
     (intern
      (completing-read



reply via email to

[Prev in Thread] Current Thread [Next in Thread]