emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit 36059e0b88: test: Set protocol.file.allow=alway


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit 36059e0b88: test: Set protocol.file.allow=always to restore old Git behavior
Date: Tue, 8 Nov 2022 22:58:41 -0500 (EST)

branch: elpa/git-commit
commit 36059e0b881cb1465cb5ad0099e55e00845a8222
Author: Kyle Meyer <kyle@kyleam.com>
Commit: Kyle Meyer <kyle@kyleam.com>

    test: Set protocol.file.allow=always to restore old Git behavior
    
    Under Git v2.38.1, the magit-get and magit-toplevel:submodule tests
    fail due to clone errors.  Both of these tests add a submodule with a
    _local_ URL.  As of a1d4f67c12 (transport: make `protocol.file.allow`
    be "user" by default, 2022-10-01) [*], Git prevents submodule
    initialization from "file://" (and bare local) sources by default for
    security reasons.
    
    In the context of Magit's test suite, this isn't a security risk, so
    teach magit-with-test-directory to add the file protocol to the list
    of allowed protocols.
    
    [*] This commit was brought into Git's maint-* branches for v2.30.X
        through 2.38.X.
---
 test/magit-tests.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/magit-tests.el b/test/magit-tests.el
index 0edfebcac0..786b87897c 100644
--- a/test/magit-tests.el
+++ b/test/magit-tests.el
@@ -37,7 +37,10 @@
   (declare (indent 0) (debug t))
   (let ((dir (make-symbol "dir")))
     `(let ((,dir (file-name-as-directory (make-temp-file "magit-" t)))
-           (process-environment process-environment))
+           (process-environment process-environment)
+           (magit-git-global-arguments
+            (nconc (list "-c" "protocol.file.allow=always")
+                   magit-git-global-arguments)))
        (push "GIT_AUTHOR_NAME=A U Thor" process-environment)
        (push "GIT_AUTHOR_EMAIL=a.u.thor@example.com" process-environment)
        (condition-case err



reply via email to

[Prev in Thread] Current Thread [Next in Thread]