emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/jarchive b93da9f976 17/33: Do NOT implement file-attrib


From: ELPA Syncer
Subject: [elpa] externals/jarchive b93da9f976 17/33: Do NOT implement file-attributes
Date: Sat, 12 Nov 2022 17:57:56 -0500 (EST)

branch: externals/jarchive
commit b93da9f97679036032ec4488cecd51d554ebe7a7
Author: dannyfreeman <danny@dfreeman.email>
Commit: dannyfreeman <danny@dfreeman.email>

    Do NOT implement file-attributes
    
    At least not in terms of the jar.
    Navigating with `find-buffer-visiting` will use file-attributes to try
    to id an existing buffer with matching attributes. This means that
    navigating to a file in a jar, call it F2, where there exists ANOTHER
    open file, called F1, then F1 may be opened instead of F2.
    
    Instead we just return nil, which is what the system file-attributes
    implementation will do.
---
 jarchive.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/jarchive.el b/jarchive.el
index a3a3bd1f83..347f3c65de 100644
--- a/jarchive.el
+++ b/jarchive.el
@@ -57,7 +57,7 @@ See `(elisp)Magic File Names'."
           ((eq op 'file-name-nondirectory) (file-name-nondirectory file-path))
           ((eq op 'directory-file-name) (directory-file-name 
(file-name-directory jar-path)))
           ((eq op 'file-name-case-insensitive-p) (file-name-case-insensitive-p 
jar-path))
-          ((eq op 'file-attributes) (file-attributes jar-path (cadr args)))
+          ((eq op 'file-attributes) nil)
 
           ;; Predicates
           ((eq op 'file-directory-p) nil)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]