emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/scad-mode 7c061affc8: Do not derive from c-mode


From: ELPA Syncer
Subject: [nongnu] elpa/scad-mode 7c061affc8: Do not derive from c-mode
Date: Sun, 13 Nov 2022 09:59:28 -0500 (EST)

branch: elpa/scad-mode
commit 7c061affc8b9fa2bc81c05e830c135ed01879b0c
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Do not derive from c-mode
    
    See other c-like modes like java-mode, objc-mode. They all derive from
    prog-mode.
---
 scad-mode.el | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/scad-mode.el b/scad-mode.el
index 9eb0c21c97..1d0f0d4ee7 100644
--- a/scad-mode.el
+++ b/scad-mode.el
@@ -131,7 +131,7 @@ Options are axes, crosshairs, edges, scales, wireframe."
   :type '(repeat string))
 
 (defvar scad-mode-map
-  (let ((map (make-sparse-keymap)))
+  (let ((map (c-make-inherited-keymap)))
     (define-key map "\C-c\C-c" #'scad-preview)
     (define-key map "\C-c\C-o" #'scad-open)
     (define-key map "\C-c\C-e" #'scad-export)
@@ -187,7 +187,7 @@ Options are axes, crosshairs, edges, scales, wireframe."
 (add-to-list 'auto-mode-alist '("\\.scad$" . scad-mode))
 
 ;;;###autoload
-(define-derived-mode scad-mode c-mode "SCAD"
+(define-derived-mode scad-mode prog-mode "SCAD"
   "Major mode for editing OpenSCAD code.
 
 To see what version of CC Mode you are running, enter `\\[c-version]'.
@@ -204,12 +204,10 @@ Key bindings:
   (add-hook 'completion-at-point-functions
             #'scad-completion-at-point nil 'local)
   (c-initialize-cc-mode t)
-  ;; (setq local-abbrev-table scad-mode-abbrev-table
-  ;;       abbrev-mode t)
-  (use-local-map scad-mode-map)
-  (c-set-offset (quote cpp-macro) 0 nil)
+  (setq abbrev-mode t)
   (c-init-language-vars scad-mode)
   (c-basic-common-init 'scad-mode c-default-style)
+  (c-set-offset 'cpp-macro 0 nil)
   (c-font-lock-init)
   (c-run-mode-hooks 'c-mode-common-hook))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]