[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/corfu 4236473373 3/3: Expand comment
From: |
ELPA Syncer |
Subject: |
[elpa] externals/corfu 4236473373 3/3: Expand comment |
Date: |
Thu, 24 Nov 2022 08:57:27 -0500 (EST) |
branch: externals/corfu
commit 4236473373428b7a7e22c19b2aaf6202e4d864db
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>
Expand comment
---
extensions/corfu-popupinfo.el | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/extensions/corfu-popupinfo.el b/extensions/corfu-popupinfo.el
index bb1dd4287a..79dda0059d 100644
--- a/extensions/corfu-popupinfo.el
+++ b/extensions/corfu-popupinfo.el
@@ -235,8 +235,11 @@ all values are in pixels relative to the origin. See
;; since lines will get wrapped.
(when (<= (car size) max-width)
(cons (+ margin (car size))
- ;; Ensure that popup has at least a height of 1,
- ;; which is the minimum frame height (#261).
+ ;; XXX HACK: Ensure that popup has at least a height of
1,
+ ;; which is the minimum frame height (#261). Maybe we
+ ;; should ask upstream how smaller frames can be created.
+ ;; I only managed to create smaller frames by setting
+ ;; `window-safe-min-height' to 0, which feels
problematic.
(min (max (cdr size) lh) max-height))))))
(cons (+ margin max-width) max-height))))
@@ -383,7 +386,7 @@ the candidate popup, its value is 'vertical, 'right or
'left."
corfu-popupinfo--lock-dir area-d
corfu-popupinfo--candidate candidate
corfu-popupinfo--coordinates new-coords)
- ;; HACK: Force margin update. For some reason, the call to
+ ;; XXX HACK: Force margin update. For some reason, the call to
;; `set-window-buffer' in `corfu--make-frame' is not effective the
;; first time. Why does Emacs have all these quirks?
(when margin-quirk