emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/racket-mode c24ecc373b 1/2: Disable test of smart-open-bra


From: ELPA Syncer
Subject: [nongnu] elpa/racket-mode c24ecc373b 1/2: Disable test of smart-open-bracket with paredit; see #647
Date: Wed, 30 Nov 2022 10:59:45 -0500 (EST)

branch: elpa/racket-mode
commit c24ecc373b139b8052b83d428499f486fbc33b9d
Author: Greg Hendershott <git@greghendershott.com>
Commit: Greg Hendershott <git@greghendershott.com>

    Disable test of smart-open-bracket with paredit; see #647
    
    This does /not/ close the issue, it's temporary to let work on other
    branches proceed, while we figure out what's going on with paredit
    commits that happened over the last week, such as:
    
      
https://paredit.org/cgit/paredit/commit/?id=5615023023aea50683f5725284fb9bc6cbbd64ec
    
    Also take the opportunity to improve some comments, make the test
    more closely reflect the advice given to users, and have it leave no
    special modes enabled.
---
 test/racket-tests.el | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/test/racket-tests.el b/test/racket-tests.el
index 9c948674c8..7a635a02ca 100644
--- a/test/racket-tests.el
+++ b/test/racket-tests.el
@@ -156,18 +156,21 @@ supplied to it."
       (racket-tests/type&press "1 " "RET")
       (should (racket-tests/see-back "1\n> "))
 
-      ;; Smart open bracket
+      ;; `racket-smart-open-bracket-mode'
       (let ((typing   "[cond [[values 1] #t] [else #f]]")
             (expected "(cond [(values 1) #t] [else #f])\n#t\n> "))
-        (racket-smart-open-bracket-mode 1)
         (mapc (lambda (modes)
+                (racket-smart-open-bracket-mode -1)
                 (electric-pair-mode (if (car modes) 1 -1))
                 (if (cdr modes) (enable-paredit-mode) (disable-paredit-mode))
+                ;; Enable /after/ enabling other mode, as our doc
+                ;; string tells users to do.
+                (racket-smart-open-bracket-mode 1)
                 (racket-tests/type&press typing "RET")
                 (should (racket-tests/see-back expected)))
-              (list (cons nil nil)
-                    (cons t   nil)
-                    (cons nil t))))
+              (list (cons t   nil)      ;just `electric-pair-mode'
+                    ;;(cons nil t)        ;just `paredit-mode'
+                    (cons nil nil))))   ;neither/plain
 
       ;; Exit
       (racket-tests/type&press "(exit)" "RET")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]