emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ergoemacs-mode 892dbe31eb 2/2: nadvice doesn't work for


From: ELPA Syncer
Subject: [elpa] externals/ergoemacs-mode 892dbe31eb 2/2: nadvice doesn't work for emacs 24.3.1, ignore advised functions
Date: Tue, 10 Jan 2023 10:57:47 -0500 (EST)

branch: externals/ergoemacs-mode
commit 892dbe31ebf1405eda5bcc41db4e5703a31464f1
Author: Matthew Fidler <matthew.fidler@gmail.com>
Commit: Matthew Fidler <matthew.fidler@gmail.com>

    nadvice doesn't work for emacs 24.3.1, ignore advised functions
---
 ergoemacs-mode.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ergoemacs-mode.el b/ergoemacs-mode.el
index 861f259764..383568e90e 100644
--- a/ergoemacs-mode.el
+++ b/ergoemacs-mode.el
@@ -471,14 +471,16 @@ after initializing ergoemacs-mode.
           (ergoemacs-mode-regular . ,ergoemacs-keymap)
           (ergoemacs-mode-send-emacs-keys . ,ergoemacs--send-emacs-keys-map)))
   (add-hook 'emulation-mode-map-alists ergoemacs-override-alist)
-  (advice-add 'undefined :around #'ergoemacs-advice-undefined)
-  (advice-add 'read-key :around #'ergoemacs-read-key))
+  (when (version<= "24.4" emacs-version)
+    (advice-add 'undefined :around #'ergoemacs-advice-undefined)
+    (advice-add 'read-key :around #'ergoemacs-read-key)))
 
 (defun ergoemacs-remove-override-keymap ()
   "Remove `ergoemacs-mode' keymaps."
   (remove-hook 'emulation-mode-map-alists 'ergoemacs-override-alist)
-  (advice-remove 'undefined #'ergoemacs-advice-undefined)
-  (advice-remove 'read-key #'ergoemacs-read-key))
+  (when (version<= "24.4" emacs-version)
+    (advice-remove 'undefined #'ergoemacs-advice-undefined)
+    (advice-remove 'read-key #'ergoemacs-read-key)))
 
 
 ;;; Frequently used commands as aliases



reply via email to

[Prev in Thread] Current Thread [Next in Thread]