emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/phps-mode eb07936ea8 036/135: added todo notes


From: Christian Johansson
Subject: [elpa] externals/phps-mode eb07936ea8 036/135: added todo notes
Date: Sun, 29 Jan 2023 03:11:02 -0500 (EST)

branch: externals/phps-mode
commit eb07936ea8323469a1680aade7546b8de2e5dbbb
Author: Christian Johansson <christian@cvj.se>
Commit: Christian Johansson <christian@cvj.se>

    added todo notes
---
 phps-mode-parser-sdt.el       |  6 ++++++
 test/phps-mode-test-ast.el    |  4 ++--
 test/phps-mode-test-parser.el | 12 ++++++------
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/phps-mode-parser-sdt.el b/phps-mode-parser-sdt.el
index c4c3f52583..38c875efc3 100644
--- a/phps-mode-parser-sdt.el
+++ b/phps-mode-parser-sdt.el
@@ -3161,6 +3161,12 @@
 (puthash
  359
  (lambda(args terminals)
+   ;; TODO Should probably have a expression / statement buffer of mentioned 
symbols and do a parse each time a expression / statement reaches its terminus
+
+   ;; TODO Declare variable in bookkeeping and imenu here
+   (message "expr-assign-variable-by-expr")
+   (message "args: %S" args)
+   (message "terminals: %S" terminals)
    `(
      ast-type
      expr-assign-variable-by-expr
diff --git a/test/phps-mode-test-ast.el b/test/phps-mode-test-ast.el
index b52a37be96..0b08687110 100644
--- a/test/phps-mode-test-ast.el
+++ b/test/phps-mode-test-ast.el
@@ -26,7 +26,7 @@
    (lambda()
       (let ((parse (phps-mode-parser-parse)))
         (message "Left-to-right with right-most derivation:\n%S\n" parse)
-        (dolist (production-number (reverse parse))
+        (dolist (production-number parse)
           (let ((production
                  (phps-mode-parser--get-grammar-production-by-number
                   production-number)))
@@ -65,7 +65,7 @@
    (lambda()
       (let ((parse (phps-mode-parser-parse)))
         (message "Left-to-right with right-most derivation:\n%S\n" parse)
-        (dolist (production-number (reverse parse))
+        (dolist (production-number parse)
           (let ((production
                  (phps-mode-parser--get-grammar-production-by-number
                   production-number)))
diff --git a/test/phps-mode-test-parser.el b/test/phps-mode-test-parser.el
index c12c38d2fe..44a5eceb53 100644
--- a/test/phps-mode-test-parser.el
+++ b/test/phps-mode-test-parser.el
@@ -76,7 +76,7 @@
 
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))
@@ -129,7 +129,7 @@
    (lambda()
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))
@@ -150,7 +150,7 @@
    (lambda()
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))
@@ -171,7 +171,7 @@
    (lambda()
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))
@@ -192,7 +192,7 @@
    (lambda()
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))
@@ -213,7 +213,7 @@
    (lambda()
      (let ((parse (phps-mode-parser-parse)))
        (message "Left-to-right with right-most derivation:\n%S\n" parse)
-       (dolist (production-number (reverse parse))
+       (dolist (production-number parse)
          (let ((production
                 (phps-mode-parser--get-grammar-production-by-number
                  production-number)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]