[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 28.0.90; duplicate checks in erc--switch-to-buffer

From: J.P.
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:07:43 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings@gmail.com> writes:

> The entire sexp starting with `with-current-buffer ...` can be removed
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they saw
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? No
worries if not. This is great regardless.

Thanks again,

[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93

reply via email to

[Prev in Thread] Current Thread [Next in Thread]