[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Deleting branch features/erc-message-tags

From: J.P.
Subject: Re: Deleting branch features/erc-message-tags
Date: Sat, 26 Mar 2022 23:40:33 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "J.P." <jp@neverwas.me>
>> Cc: Vibhav Pant <vibhavp@gmail.com>, Eli Zaretskii <eliz@gnu.org>, Lars
>>  Ingebrigtsen <larsi@gnus.org>, bandali@gnu.org
>> Date: Sat, 26 Mar 2022 11:56:50 -0700
>> The one patch this branch contains was applied as:

Sorry, that's confusing. I meant "applied to trunk as". But as written
it reads like the commit below is the one atop that feature branch. But
that would be aa6bcdf0c33ff86eb92794202ee5bd70f6d9bde3, which contains
the exact same changes and log message. It's just not reachable from
HEAD (but was still effectively merged in the sense that its twin below
has been part of Emacs since 27 and is indeed an ancestor of HEAD).

>>   commit 2205546269bf5af01d766dc38720f71046b08dfa
>>   Author: Vibhav Pant <vibhavp@gmail.com>
>>   Date:   Mon Apr 24 11:57:46 2017 +0530
>>       Add support for IRCv3 message tags.
>>       * erc-backend.el:
>>         erc-response: Add `tags' element.
>>         Add (erc-parse-tags).
>>         (erc-parse-server-response): Use (erc-parse-tags) to parse message
>>         tags (if any), and store them in `erc-resopnse' struct.
>>       * erc.el: (erc-display-message): Expose message tags with text
>>         properties of the corresponding message line.
>>    lisp/erc/erc-backend.el | 30 +++++++++++++++++++++++++-----
>>    lisp/erc/erc.el         |  5 ++++-
>>    2 files changed, 29 insertions(+), 6 deletions(-)
>> I therefore move that the branch be deleted. If no one objects or beats
>> me to it, I'll follow through on or around April 2, 2022. Thanks.
> What about the one commit on this branch?  Do you suggest to merge it
> or discard it, and why?

I suggest discarding the branch because its changes have already been
incorporated. Thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]