[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#60428: 29.0.60; ERC 5.4.1: Fix default-port regression in erc-se

From: J.P.
Subject: Re: bug#60428: 29.0.60; ERC 5.4.1: Fix default-port regression in erc-select-read-args
Date: Sun, 01 Jan 2023 17:41:12 -0800
User-agent: Gnus/5.13 (Gnus v5.13)

v2. Respect `erc-prompt-for-password'. Remove `run-at-time' hack from
regression fix.

"J.P." <jp@neverwas.me> writes:

> The proposed patch abandons most of the envisioned niceties and
> instead employs a hack to just force a non-local exit and schedule a
> call to `erc-tls' when appropriate. It also instructs users to do that
> themselves in the future (issue an M-x erc-tls, that is). Hopefully,
> this makes for an acceptable compromise.

I've forsaken the first part out of an abundance of caution. So this now
just prints a warning and proceeds with a non-TLS connection. If anyone
finds that unsatisfactory, please say something.

> BTW, a POC patch set far more faithful to the original breadth of the
> feature (and way less hacky) is also attached. Perhaps it'll inform
> further exploration in this area down the road (but not for Emacs 29).

IOW, the de facto goal here is to make interactive `erc' a "universal"
entry point for both plain and TLS connections.

Attachment: 0000-v1-v2.diff
Description: Text Data

Attachment: 0001-Fix-default-port-regression-in-erc-select-read-args.patch
Description: Text Data

Attachment: 0002-5.6-Be-smarter-about-switching-to-TLS-from-M-x-erc.patch
Description: Text Data

Attachment: 0003-5.6-Add-display-option-for-interactive-ERC-invocatio.patch
Description: Text Data

Attachment: 0004-5.6-Optionally-prompt-for-more-ERC-entry-point-param.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]