Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

[Manish]

On Wed, Aug 19, 2009 at 8:12 PM, Bernt Hansen wrote:
> Nick Dokos writes:
>
>> Thanks! IIUC, there are then multiple forks in the decision tree:
>>
>>     o running on Windows or on something else?
>>
>>     o if on Windows, running native or under cygwin?
>>
>>     o what shell am I using? cmd.exe and bash under cygwin accept
>>     different syntax - in particular, the GITDIR=foo solution of
>>     setting env variables has no hope of working under cmd.exe -
>>     is that correct?
>>
>> Sounds complicated. Maybe the best solution for now is to punt on
>> the git information on Windows?
>>
>>   (when (not (member system-type '(ms-dos windows-nt cygwin)))
>>      ...add git info...)
>>
>> What about system-type == "darwin"? Does Bernt's code work there?
>
> Yes it'll be complicated. Right now I think we should punt and just go
> back to the old org-version reporting for windows until we can get a
> better working solution since the current version breaks on windows.
> I'll try to provide a patch for this.
>
> Manish:
>
> What value do you have for system-type? I expect it says 'windows-nt'

Yes, it does.

>
> If that's true then the problem is determining if
> - git is installed
>  - what version? Msysgit? cygwin git?
> - what shells are available (since CMD.exe has little hope of working)
>  - msysgit bash
>  - cygwin shell
>  - cmd (won't work if msysgit was installed with git in the msysgit
>      bash shell only)
> - running some other shell (git-bash, cygwin) so the git executable is
>  available and provide the right syntax for each to Do The Right
>  Thing(tm)

Do we test if git is installed if we are on a non-Windows system or
show whatever error shell returns in case git is not installed?

I tried calling cygwin git from CMD shell and it seems to work okay.
So I am guessing we need to figure out how to correctly pass git
command from Emacs to Windows shell.  I will try to find examples from
Org's PDF processing code.

>
> Right now I'm inclined to skip the git-version magic if system-type is
> windows-nt just to stop it from breaking on that platform.

Sure.  I will share some information/examples if I can find anything
to make it work.

Thanks
-- 
Manish>