[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Re[6]: [Orgmode] programming for org-mode

From: David Maus
Subject: Re: Re[6]: [Orgmode] programming for org-mode
Date: Mon, 09 Aug 2010 21:16:06 +0200
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj┼Ź) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Ivanov Dmitry wrote:

>I modified the scheme and the function. I think, that these 2 if-s
>just complicate the code for comprehension: we have 3 cases, for each
>of them we should return the appropriate value.

Yes, `cond' is more suitable here.

>All the tests work fine with the new version.
>When I tried

>(org-read-prop "(1 2 3))") -> (1 2 3)

>It gave me (1 2 3), ignoring the last ')'. Seems to be the read
>function bug.

Not sure if it is a bug or the indended behavior.  `read' returns the
first valid lisp expression in finds.  E.g.

(read "(a b c) foo bar") => (a b c)

I think this is good enough at this place.  A complete solutation
would require to parse the entire string.

>At last I got rid of these nasty little squares on the scheme :)


Of course the next step for you would be to tame the beast called git
and prepare a proper patch.  The steps are:

 1. create a topic branch for the fix

 2. change the function, commit to topic branch and provide a proper
    commit message

 3. create a patch against current master

 4. send the patch manually or using git send-email

  -- David
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... address@hidden
Email..... address@hidden

Attachment: pgpIgiWdpwg0u.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]