[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] [PATCH 1/2] org-agenda: introduce org-agenda-today and org

From: Julien Danjou
Subject: Re: [Orgmode] [PATCH 1/2] org-agenda: introduce org-agenda-today and org-agenda-get-day-face
Date: Mon, 08 Nov 2010 20:28:23 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)

On Mon, Nov 08 2010, Carsten Dominik wrote:

> can you please rename org-agenda-today to org-agenda-today-p?
> I think it would make its use clearer.

I think you misread the function. I've added org-agenda-today which
returns today, and just rewrite org-agenda-todayp to use that one.

> Also, couly you please specify in the docstring of org-agenda-day-face-
> function how the day is coming in into the user-defined function?  As a day
> number or a calendar date list?

It's a calendar date list.

Updated patch attached.

>From e59409e447f18d92eca9c8faf271901c437746ff Mon Sep 17 00:00:00 2001
From: Julien Danjou <address@hidden>
Date: Mon, 8 Nov 2010 18:23:07 +0100
Subject: [PATCH] org-agenda: add org-agenda-day-face-function

* lisp/org-agenda.el (org-agenda-day-face-function): New variable.
(org-agenda-get-day-face): Use org-agenda-day-face-function.

Signed-off-by: Julien Danjou <address@hidden>
 lisp/org-agenda.el |   20 +++++++++++++++-----
 1 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 98371e6..aba85eb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -1433,6 +1433,14 @@ determines if it is a foreground or a background color."
                                   (string :tag "Color")
                                   (sexp :tag "Face"))))))
+(defcustom org-agenda-day-face-function nil
+  "Function called to determine what face should be used to display a day.
+The only argument passed to that function is the day in the
+calendar date list format.  It should returns a face, or nil if it
+does not want to specify a face and let the normal rules apply."
+  :group 'org-agenda-line-format
+  :type 'function)
 (defcustom org-agenda-category-icon-alist nil
   "Alist of category icon to be displayed in agenda views.
@@ -3108,11 +3116,13 @@ no longer in use."
 (defun org-agenda-get-day-face (date)
   "Return the face DATE should be displayed with."
-  (cond ((org-agenda-todayp date)
-        'org-agenda-date-today)
-       ((member (calendar-day-of-week date) org-agenda-weekend-days)
-        'org-agenda-date-weekend)
-       (t 'org-agenda-date)))
+  (or (and (functionp org-agenda-day-face-function)
+          (funcall org-agenda-day-face-function date))
+      (cond ((org-agenda-todayp date)
+            'org-agenda-date-today)
+           ((member (calendar-day-of-week date) org-agenda-weekend-days)
+            'org-agenda-date-weekend)
+           (t 'org-agenda-date))))
 ;;; Agenda timeline

Julien Danjou
// ᐰ <address@hidden>   http://julien.danjou.info

reply via email to

[Prev in Thread] Current Thread [Next in Thread]