[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] org-babel -- Improper syntax error in session mode?

From: Eric Schulte
Subject: Re: [O] org-babel -- Improper syntax error in session mode?
Date: Mon, 20 Jun 2011 12:23:24 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

I've changed the python session evaluation so that it explicitly sends a
RET to the inferior Python process after every line of input.  The
attached patch makes this change.  I can confirm that this fixes the
problem in your example (when an empty line is placed between the block
and the subsequent print statement), however, could you please test it
on a variety of other python blocks to confirm it doesn't seem to break
existing behavior (I'm not a python user).

If this looks safe then I'll apply it to the main repo.

Thanks! -- Eric

>From 1edad6a87bb5491061efaf597fa38b9190387232 Mon Sep 17 00:00:00 2001
From: Eric Schulte <address@hidden>
Date: Mon, 20 Jun 2011 12:18:09 -0700
Subject: [PATCH] ob-python: Send RET after every line w/session evaluation

* lisp/ob-python.el (org-babel-python-evaluate-session): Send
  comint-send-input after every line when interacting with an
  interactive python process.
 lisp/ob-python.el |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/ob-python.el b/lisp/ob-python.el
index f3f4a03..6cb2c44 100644
--- a/lisp/ob-python.el
+++ b/lisp/ob-python.el
@@ -267,9 +267,11 @@ last statement in BODY, as elisp."
              (session org-babel-python-eoe-indicator t body)
            (let ((comint-process-echoes nil))
-             (input-body body)
-             (insert org-babel-python-eoe-indicator)
-             (comint-send-input))) 2) "\n"))
+             (mapc
+              (lambda (line)
+                (insert line) (comint-send-input nil t))
+              (append (split-string body "[\n\r]") (list 
+         2) "\n"))
        (let ((tmp-file (org-babel-temp-file "python-")))

Nick Dokos <address@hidden> writes:

> Herbert Sitz <address@hidden> wrote:
>> Eric Schulte <schulte.eric <at> gmail.com> writes:
>> > I can confirm that I see the same behavior.  Also, if I manually type
>> > the body of the code block into the session I get the same error output
>> > from Python, so I don't believe this is due to a problem with Babel.
>> > 
>> It appears the problem is that the python session is interactive and is 
>> built to
>> emit output after each Python "block" (e.g., the 'for' block), before another
>> "block" of Python is entered.  If this is the way it's designed then it 
>> seems to
>> me that it's Babel's obligation to feed the Python blocks to the Python 
>> session
>> as required and then assemble the output pieces as appropriate.  Or am I 
>> missing
>> something? -- Herb
> Having babel recognize python blocks in order to feed them to the python
> interpreter as complete blocks seems a bit too much to me. Of course,
> what I think matters little: it's what Eric thinks that matters here.
> Having said that, however, I think there *is* a problem:
> If you just start the python interpreter and start typing into it:
> x = 1
> for i in range(1,5):
>   x = x + i
>   print x
> print "Did it work?"
> the problem becomes obvious: the interpreter is still in "indented mode"
> and complains about the last print, because it is not "properly"
> indented.  OTOH, if you exit "indented mode" by pressing another RET
> before the final print, the interpreter is happy. This is a kludge used
> by the interactive interpreter to accommodate python's reliance on
> indentation to delimit block structure.
> That however does not work with babel: even if I leave empty lines
> between the print x and the last print, the error persists. Apparently,
> babel does not send the empty lines to the interpreter. If there is a
> bug in babel, it seems to me this is it.
> Nick

Eric Schulte

reply via email to

[Prev in Thread] Current Thread [Next in Thread]