[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Org-special-blogs does not make well-formed xhtml

From: Christian Moe
Subject: Re: [O] Org-special-blogs does not make well-formed xhtml
Date: Thu, 06 Oct 2011 12:17:16 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20110624 Thunderbird/5.0

Hi, Carsten,

I've submitted a patch separately. It seems to play nice with the enclosed test file.

If org-special-blocks is supposed to become part of the core (it's moved out of contrib, but we still have to require it), it might make sense to just move the html and latex formatting code into org-html.el and org-latex.el respectively, together with the handling of blockquotes, verses, centering etc.


On 10/4/11 11:33 PM, Carsten Dominik wrote:
Hi Christian,

for now I have reverted the patch.  WOuld you like to work on a better one?

- Carsten

On 4.10.2011, at 21:01, Christian Moe wrote:


Carsten, thanks.

Jambunathan's probably right, though, that this fix (while necessary) is 
incomplete. Sorry, I hadn't thought it through.

Now, when the first paragraph of a special block comes right after the #+BEGIN_WHATEVER line, it 
will just come as the first text node of the<div>  block, and will not be wrapped in 
a<p>  element. So among other things, any special CSS styling for<p>s will not be 
applied to it.

It's not a big deal -- if you need a<p>  (and often you really don't) the 
workaround is as simple as leaving an empty line between #+BEGIN_WHATEVER and the 
first paragraph.

But I guess it would be more consistent/expected/helpful behavior for special-blocks 
to start a new paragraph -- this time *after* the opening<div>  tag and not 
around it!


On 10/4/11 4:36 PM, Jambunathan K wrote:

Carsten Dominik<address@hidden>   writes:
I see no reason to not uncomment this line.  Shall we just do this?

Shouldn't a paragraph be opened/closed while entering/leaving the div.

,---- See org-xhtml-format-environment
|     (center
|      (case beg-end
|        (BEGIN
|       (org-lparse-end-paragraph)
|       (insert "\n<div style=\"text-align: center\">")
|       (org-lparse-begin-paragraph))
|        (END
|       (org-lparse-end-paragraph)
|       (insert "\n</div>")
|       (org-lparse-begin-paragraph))))

We can always open a paragraph gratis, because empty paragraphs are
pruned at the end of export.

Attachment: special-blocks-test.org
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]