[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Location of OpenDocument style files should be configurable
From: |
Ulrich Mueller |
Subject: |
Re: [O] Location of OpenDocument style files should be configurable |
Date: |
Thu, 29 Dec 2011 19:32:31 +0100 |
>>>>> On Thu, 29 Dec 2011, Achim Gratz wrote:
> IMHO, an _installed_ org mode should never heuristically search
> any support files -- the location should either be recorded into
> org-install.el as a constant or made configurable as a defcustom,
> whichever is more appropriate.
Such heuristic searches are not uncommon in other elisp packages.
But I agree that it's the wrong approach. If the location is known at
build time, then it should be recorded somewhere in the lisp code.
>> Now my question, could the defconst be changed to a defvar, so that
>> we can specify the location in our site-start file? Or, preferably,
>> could the etcdir specified in "make" command be honoured in the
>> lisp code?
> Jambunathan will have to answer that, but a defvar seems the wrong
> solution to this problem. Also site-start should probably not be
> (mis-)used to configure the behaviour of packages that the user may
> not actually use.
Well, we don't configure the behaviour, but just fix a wrong path.
Also Gentoo's site-start file requires org-install if org-mode is
installed on the user's system. So, for the user there won't be a
visible difference if the path is defined in org-install or in
site-start.
Of course, it is preferred if the upstream package gets things right,
so that we don't have to adjust them on the distro level.
Ulrich