[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch][test] Avoid writes to non-temp test-example files

From: Martyn Jago
Subject: Re: [O] [patch][test] Avoid writes to non-temp test-example files
Date: Thu, 05 Jan 2012 18:31:15 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (darwin)

Achim Gratz <address@hidden> writes:

> Martyn Jago <address@hidden> writes:
>> Attached is a patch to modify all tests that currently write to non-temp
>> test-example files such as `testing/babel.org'. Instead, the tests now
>> write to temp files, which are thrown away at the conclusion of the
>> test.
> With NTemacs24 on Win7, if neither TMP nor TEMP environment variables
> are set, it choses C:\ as the temp directory, which isn't writable for
> normal users.  This makes all tests fail that write to temporary files.
> I'm not sure how exactly it ends up with C:\, but this should either be
> fixed or we need to make sure that TEMP or TMP is set from Makefile
> before running tests.
> Regards,
> Achim.

Wow! Strictly speaking I guess that's an NTemacs24 bug, but we do have
the option of over-riding the default Emacs tmp location, which may
incur some extra house-keeping by the test-runners. I will leave that
decision to a maintainer.

I guess the makefile could issue a message on windows if an env var is
not set?

Best, Martyn

reply via email to

[Prev in Thread] Current Thread [Next in Thread]