[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Capture: Expand keyword within %(SEXP) in template

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Capture: Expand keyword within %(SEXP) in template
Date: Sun, 04 Nov 2012 14:10:33 +0100

Ryo TAKAISHI <address@hidden> writes:

> I fixed and added document in docstring & org.texi.

Thank you.

> +                  @r{If sexp's attr is link keyword (@code{%:keyword}),}
> +                  @r{it will be expanded using @code{org-store-link-plist}.}

Documentation should not contain a reference to `org-store-link-plist':
it is an internal variable, therefore, it is of no use for the end user.
I suggest something along the lines of:

  Evaluate Elisp SEXP and replace with the address@hidden
  convenience, %:keyword (see above) placeholders within the expression
  will be expanded.}. The sexp must return a string.

>    %(sexp)     Evaluate elisp `(sexp)' and replace with the result.
> +              If sexp's attr is link keyword (%:keyword), it will
> +              be expanded using `org-store-link-plist`.


Otherwise the code is fine. Would you provide a complete patch, i.e.
with `git format-patch'? The changelog entry may be:

  org-capture: Expand keywords within %(sexp) placeholder in template

  * org-capture.el (org-capture--expand-keyword-in-embedded-elisp): New
  (org-capture-expand-embedded-elisp): Use new function.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]