[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mod

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode
Date: Tue, 06 Nov 2012 18:02:40 +0100

Toby Cubitt <address@hidden> writes:

> org-beginning-of-line uses org-beginning-of-visual-line when
> line-move-visual is enabled. I'm not sure if line-mode-visual can be
> disabled when visual-line-mode is enabled. If so, org-beginning-of-line
> should maybe test for either line-mode-visual *or* visual-line-mode.

`beginning-of-visual-line' either set locally `line-move-visual' to t or
use `vertical-motion', which doesn't care about `lime-move-visual'
value. Thus, as one could expect, `line-move-visual' has no effect on
horizontal scrolling.

IMO, checking this variable is a no-op.

Btw, if you plan to patch this area, could you provided tests for it
(see test-org/end-of-line in test-org.el)? As I can testify, there is
a high risk of regression in that area.


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]