[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mod

From: Toby Cubitt
Subject: Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode
Date: Tue, 6 Nov 2012 19:46:29 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Nov 06, 2012 at 06:46:27PM +0100, Nicolas Goaziou wrote:
> Toby Cubitt <address@hidden> writes:
> > Aha! You may well be right. In which case why is `org-beginning-of-line'
> > doing this:
> >
> >   (if (org-bound-and-true-p line-move-visual)
> >       (beginning-of-visual-line 1)
> >     (beginning-of-line 1))
> >
> > Shouldn't it be doing this instead?
> >
> >   (if (org-bound-and-true-p visual-line-mode)
> >       (beginning-of-visual-line 1)
> >     (beginning-of-line 1))
> Indeed. Do you want to provide a patch (you get bonus points for
> regression tests)?

I guess you want regression tests for `end-of-line' with
`visual-line-mode' enabled? (There aren't any tests for beginning-of-line
in test-org.el currently, and the fix to org-beginning-of-line won't
actually change the behaviour, just make the code more correct.)

I've made an attempt in the attached patch, which also fixes
org-beginning-of-line as discussed.

Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: address@hidden
web:   www.dr-qubit.org

Attachment: 0001-Bug-fix-in-org-beginning-of-line-visual-line-motion.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]