[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] lisp/ob.el (org-babel-result-cond)

From: Eric Schulte
Subject: Re: [O] [PATCH] lisp/ob.el (org-babel-result-cond)
Date: Tue, 11 Dec 2012 07:41:29 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Achim Gratz <address@hidden> writes:

> This has been in there for a while and only been visible due to
> byte-compiler warnings about free variable result-params.  Either the
> tests don't really exercise this code path well or we've been lucky that
> result-params was bound to the correct value during all those calls.

The `result-params' variable is *always* in scope every time this macro
is called.  In fact previously the Babel language files were told to
expect some variables to always be in scope without their being
explicitly passed in as parameters.  We've since begun passing these
things explicitly to the language functions to appease the compiler.

I'd like to apply this patch, however the format is not detected by git
am.  Could you re-generate this patch using git format-patch and attach
the resulting file?


Eric Schulte

reply via email to

[Prev in Thread] Current Thread [Next in Thread]