[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] bug#12905: 24.2.50; org: edit source block causes data loss

From: Le Wang
Subject: Re: [O] bug#12905: 24.2.50; org: edit source block causes data loss
Date: Fri, 14 Dec 2012 07:40:15 +0800

On Fri, Dec 14, 2012 at 12:25 AM, Bastien <address@hidden> wrote:
> I superseded the first one with my patch, and just applied the
> third one.
> Can you explain the bug behind the second one?

If I press C-' before on a line BEFORE "+begin_src ...", then doing
comparison with ">=" with beg==nil and end==nil causes
"wrong-type-argument" error.

"test-org-src/point-outside-block" test case should fail, but because
"wrong-type-argument" is also an error, it is passing.  :(

I've changed "(error ..." to raise an org-src specific error to
facilitate testing.  Commits rebased to master are attached.

A note:

I did change this line:

    (end (copy-marker (make-marker) t))

(make-marker) makes a temporary new marker that's never used.  ;)


Attachment: 0001-don-t-use-copy-marker-nil-t-for-Emacs-23-compat.patch
Description: Binary data

Attachment: 0002-fix-org-edit-src-code-invoked-outside-src-block.patch
Description: Binary data

Attachment: 0003-test-org-src-checks-for-org-src-generated-error.patch
Description: Binary data

Attachment: 0004-add-org-src-error-error-condition.patch
Description: Binary data

Attachment: 0005-remove-extraneous-if-condition.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]