[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] PATCH: Habit consistency always show DONE days green option

From: Max Mikhanosha
Subject: [O] PATCH: Habit consistency always show DONE days green option
Date: Mon, 06 May 2013 10:47:09 -0400
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj┼Ź) APEL/10.6 Emacs/23.3.50 (x86_64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)

I had always disliked how if you miss a habit deadline and then go on
a several day streak, first day still show up red. Makes it hard to
visually see "green streaks"

Following patch adds a new variable `org-habit-show-done-always-green'
to fix that. It defaults to off, if enough people like it we can
make it new default.

To illustrate the difference in display, try to count number of two
day streaks in below screen-shots.

Current display:


With new option:


Note that no information is lost, you can still figure out if streak
started after missing a deadline, by color of the previous day.


From 5c7f9b63b6021631b19b883760340a18024e6344 Mon Sep 17 00:00:00 2001
From: Max Mikhanosha <address@hidden>
Date: Mon, 6 May 2013 09:26:10 -0400
Subject: [PATCH] Add option to always show DONE days as green on consistency
 graph. It can be enabled by setting
 `org-habit-show-done-alwyays-green' variable to t.

* lisp/org-habit.el (org-habit-get-faces): Add show done days green option
 lisp/org-habit.el | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lisp/org-habit.el b/lisp/org-habit.el
index 8465ba4..0899f45 100644
--- a/lisp/org-habit.el
+++ b/lisp/org-habit.el
@@ -85,6 +85,12 @@ (defcustom org-habit-completed-glyph ?*
   :version "24.1"
   :type 'character)
+(defcustom org-habit-show-done-always-green nil
+  "If non-nil, a DONE day will always be green in consistency
+graph, even if it was done after deadline"
+  :group 'org-habit
+  :type 'boolean)
 (defface org-habit-clear-face
   '((((background light)) (:background "#8270f9"))
     (((background dark)) (:background "blue")))
@@ -272,8 +278,9 @@ (defun org-habit-get-faces (habit &optional now-days 
scheduled-days donep)
       (if donep
          '(org-habit-ready-face . org-habit-ready-future-face)
        '(org-habit-alert-face . org-habit-alert-future-face)))
-     (t
-      '(org-habit-overdue-face . org-habit-overdue-future-face)))))
+     ((and org-habit-show-done-always-green donep)
+      '(org-habit-ready-face . org-habit-ready-future-face))
+     (t '(org-habit-overdue-face . org-habit-overdue-future-face)))))
 (defun org-habit-build-graph (habit starting current ending)
   "Build a graph for the given HABIT, from STARTING to ENDING.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]