[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ob-fortran.el, add matrix as input
From: |
Eric Schulte |
Subject: |
Re: [O] [PATCH] ob-fortran.el, add matrix as input |
Date: |
Thu, 06 Jun 2013 10:17:43 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Achim Gratz <address@hidden> writes:
> Eric Schulte writes:
>> Applied, Thanks!
>>
>> Litvinov Sergey <address@hidden> writes:
>>
>>> I would like to propose a tiny patch which adds matrix as an input for
>>> ob-fortran.el. See changes in testing/examples/ob-fortran-test.org for
>>> the examples.
>
> I've not had time to test with anything, but this patch seems to make
> the same faulty assumption about tables always being a list of lists
> that I fixed just a few days ago someplace else. When dealing with
> tables you have to expect hlines in place of a list with the row values
> otherwise you will not correctly recognize them.
>
Agreed, I've just updated the matrix check in ob-fortran to be more
strict so that tables with hlines will not be treated as matrices.
A more sophisticated solution to correctly interpret hlines in a manner
acceptable to Fortran would require more Fortran knowledge than I
posses.
Best,
>
>
> Regards,
> Achim.
--
Eric Schulte
http://cs.unm.edu/~eschulte