[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Timestamps: Handle sub-10-min ranges when updating times

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Timestamps: Handle sub-10-min ranges when updating timestamps
Date: Thu, 08 Aug 2013 10:22:58 +0200

Trevor Murphy <address@hidden> writes:

> Schedule an event for today with a five-minute duration.  E.g:
> * TODO test out bug in `org-schedule'
> SCHEDULED: <2013-08-07 Wed 17:00-17:05>
> Then hit C-c C-s (or however you have `org-schedule' bound).  With the
> default setup, you'd expect to see the following prompt in the
> minibuffer:
> Date+time [2013-08-07]: 17:00+0:05
> however what you'll get instead is:
> Date+time [2013-08-07]: 17:00+0:5
> The latter is not a valid time spec.  If you simply accept it, then at
> least on my install org reschedules the event to:
> SCHEDULED: <2013-08-07 Wed-17:00>
> Which is not what I intended.  I'll add that you can get the same buggy
> behavior from any command that calls `org-time-stamp' on an
> already-timestamped event with <10 minute duration.

OK. Thank you for the explanation.

> I tested that and it felt noticeably slower when I called
> `org-reschedule'.  The extra `if' and `concat' did not feel slower.  I
> didn't do explicit timings because of the subjective feel (also because
> I'm not really sure how to do those tests yet).  That being said, I
> agree with you.

I doubt the difference between the two is noticeable. Something else
happened when calling `org-reschedule'.

> If you prefer, I'll resubmit the patch without the if => when and using
> the format string.  

Please do. I'll apply it then.


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]