[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix error prone babel table output format detection

From: Ian Kelling
Subject: Re: [O] [PATCH] Fix error prone babel table output format detection
Date: Thu, 01 May 2014 01:30:10 -0700
User-agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux)

Achim Gratz <address@hidden> writes:

> Ian Kelling writes:
>> org-babel table output uses different formatting for a list of lists,
>> but detects it incorrectly causing an error, as in this example:
>> #+begin_src emacs-lisp 
>> '((1) 2)
>> #+end_src
> So this isn't a proper table, what do you expect to happen?

I expect to be able to emacs -q, make an org mode buffer containing 
that block, do ctrl-c c on it, and not have an error message pop up and
fail to have any output. What is improper about it? Would it be better
if org did not try to format it as a table?

>> -                                       (and (listp (car result))
>> -                                            (listp (cdr (car result)))))
>> +                                       (cl-every 'listp result))
> This is wrong, because a table can come with any number of 'hline
> symbols, so ostensibly not every element will be a listp.

Yes, I agree. It will have to test if elements are listp or hline. 

> Besides, you
> can't use cl-every unless Org drops backwards compatibility with older
> Emacsen or mandates cl-lib to be present.  Even then, you'd also need to
> require cl-extra.

I forgot about the multiple parts of cl. I originally wrote it without,
and can change it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]