[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org.el (org-offer-links-in-entry): Remove code duplicati
From: |
Bastien |
Subject: |
Re: [O] [PATCH] org.el (org-offer-links-in-entry): Remove code duplication |
Date: |
Tue, 06 May 2014 11:29:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Hi Albert,
thanks for the patch.
Albert Krewinkel <address@hidden> writes:
> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid
> code duplication.
This is not really code duplication, as the output of `org-any-link-re'
is different from the output of the current sexp in the code.
That said, the change looks good anyway. Can you double-check there
cannot be any problem with the value of `org-any-link-re'?
> The `re' variable defined in function `org-offer-links-in-entry' is
> string-equal to `org-any-link-re' and is hence replaced by the latter.
>
> This is a TINYCHANGE.
(TINYCHANGE should stand alone on the line.)
Thanks!
--
Bastien
- Re: [O] [PATCH] org.el (org-offer-links-in-entry): Remove code duplication,
Bastien <=