[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Make the point visible when jumping to the mark

From: Ian Kelling
Subject: Re: [O] [PATCH] Make the point visible when jumping to the mark
Date: Thu, 22 May 2014 08:40:07 -0700
User-agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux)

Bastien <address@hidden> writes:

> Hi S├ębastien,
> Sebastien Vauban <sva-news-D0wtAvR13HarG/address@hidden>
> writes:
>> Even if the goal is desirable, I thought that we may not add defadvice
>> in Emacs sources.
> True that, we need to clean things up.
> The route I will take is to apply Ian patch on master and then to
> move all advising code into a separate org-advice.el library in the
> contrib/ directory.  Any suggestion for a better name?

I considered this problem when I made the patch, and originally started
writing it to not use advise. The alternative I see is to create
org-mode versions of these functions, and binding them with the
org-mode-map to override the existing functions, like we do with other
functions. I prefer advice in these cases because the advice is simple
and it is easier for users customizing keybinds and extending
emacs. However, compared to making it a module and thus not enabled by
default, I would prefer to make org-mode versions of the
functions. Having them on by default will be more helpful to more users
overall. I would be happy to write the patch for this, if we agree.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]