emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [


From: Nicolas Richard
Subject: Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]
Date: Thu, 24 Jul 2014 16:25:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux)

Nicolas Goaziou <address@hidden> writes:

> Nicolas Richard <address@hidden> writes:
>
>> I think it should try to have at least a sensible error message. The
>> current "Before first headline" isn't quite clear (my patch doesn't
>> address this, btw).
>
> "Not in an Org mode buffer" could be better indeed.
>
> Anyway, this kind of change (including compatibility with outline.el)
> belongs to the high-level function `org-narrow-to-subtree', not the very
> specific `org-get-limited-outline-regexp'.

Agreed.

But now that I think about it, org mode simply should avoid narrow-map
completely : users (me included) won't randomly try to run
org-narrow-to-subtree outside of org buffers (and those who do deserve a
bad error message) but they might want to give "C-x n s" a try if it is
available.

While writing a patch for changing that, I see that the code is:
(if (boundp 'narrow-map)
    (org-defkey narrow-map "s" 'org-narrow-to-subtree)
  (org-defkey org-mode-map "\C-xns" 'org-narrow-to-subtree))
(if (boundp 'narrow-map)
    (org-defkey narrow-map "b" 'org-narrow-to-block)
  (org-defkey org-mode-map "\C-xnb" 'org-narrow-to-block))
(if (boundp 'narrow-map)
    (org-defkey narrow-map "e" 'org-narrow-to-element)
  (org-defkey org-mode-map "\C-xne" 'org-narrow-to-element))

IOW, org.el purposely binds in narrow-map ! So now I don't get it :
either it's in narrow-map and should be usable widely, or it's in
org-mode-map only for org-mode files.

-- 
Nico.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]