[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameter

From: Steven Rémot
Subject: Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el
Date: Sat, 20 Sep 2014 15:31:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

Thank you for your comments. I attached the fixed patch below.

On 09/20/2014 14:16, Nicolas Goaziou wrote:
This is not related to your patch, but while you're at it, use `delq' instead of `remq' (nitpick) and `dbstring-postgresql' needs to be renamed `org-babel-sql-dbstring-postgresql' or some such.
I used mysql parameters handling code as a template for writing my patch, so it suffered from the same problems. I added a second patch that renames `dbstring-mysql' to `org-babel-sql-dbstring-mysql' and that uses `delq' instead of `remq' in its implementation. I did some basic tests to ensure I didn't break anything.

Steven Rémot

Attachment: 0001-ob-sql.el-Enhance-postgresql-support.patch
Description: Text Data

Attachment: 0002-ob-sql.el-Clean-mysql-parameters-generation.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]