[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch, ox] #+INCLUDE resolves links

From: Rasmus
Subject: Re: [O] [patch, ox] #+INCLUDE resolves links
Date: Tue, 30 Sep 2014 12:18:22 +0200
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux)

Nicolas Goaziou <address@hidden> writes:

>> Just out of curiosity, what is an example of a element that can be
>> named and does not have a :contents-begin?
>   #+name: empty-drawer
>   :DRAWER:
>   :END:


>> Okay, there's a lot of improvements in that suggestion.  However, it
>> misses this case which created using only "official" shortcuts
>>      * head
>>      SCHEDULED: <2014-09-28 sun>
>>      :LOGBOOK:
>>      - Note taken on [2014-09-28 sat 12:21] \\
>>        a drawer
>>      :END:
>>      :PROPERTIES:
>>      :CUSTOM_ID: h
>>      :END:
> This was done on purpose, anticipating a patch I'm working on. Anyway,
> it doesn't matter much. I'll revert it once my work is ready.

Okay.  If you discussed on the list I missed it.

>> +elements.}.  If the @code{:only-contents} property is non-nil, only the
>> +contents of the requested element will be included, omitting any
>> +property-drawers, planning-lines, attributes, captions etc.  The
> properties (or property) drawer, planning line.
> Do you think it's worth specifying that captions and attributes will be
> ignored? It seems pretty obvious to me as they do not belong to contents
> (unlike to planning and properties drawers).

It's two extra words and maybe it's helpful to make the concept clear
to people unfamilar with org-element.  The statement "contents of the
requested element", while technically clear, is only barely
comprehensible for the uninvited.

However, it's only tweo extra words, so I'm happy to remove them if
you have strong feeling about this.

>> +             (only-contents
>> + (and (string-match ":only-contents +\\([^: \r\t\n]\\S-*\\)" value)
>> +                   (prog1 (org-not-nil (match-string 1 value))
>> +                     (setq value (replace-match "" nil nil value)))))
> Why do you need to remove match from VALUE? AFAICT, the only match that
> needs to be removed is the file name. Others are regular.

I don't know what you mean with regular.  Anyway, my reasoning is that
this INCLUDE-command

        #+INCLUDE: "/tmp/test0.org" :my-random-prop "foo"

Will give me something like:


In casual testing similar stuff happened when I did not remove the
match.  It could have been it was a bit too casual and that I
misspelling the property.  I will test this properly later.

> Mind the 80th column in your tests, and full stop at end of comments.

OK, I'll fix it.

> Besides the minor issues above, it looks good. Feel free to push it
> whenever you want.

Don't have push.


Lasciate ogni speranza o voi che entrate: siete nella mani di'machellaio

reply via email to

[Prev in Thread] Current Thread [Next in Thread]