Re: [O] [BUG] ox-taskjuggler: unable to use depends {gapduration}

[Nicolas Goaziou]

Hello,

Christian Egli <address@hidden> writes:

> No it is indeed a bug. At first I thought this was simply no longer
> working in the new exporter but I was wrong. Nicolas of course
> implemented it and way more. But there is a subtle bug. I actually found
> it because I wondered about the funny "t :taskjuggl" in the output.
> Here's the fix.
>
> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
> index 807d702..9e977f6 100644
> --- a/contrib/lisp/ox-taskjuggler.el
> +++ b/contrib/lisp/ox-taskjuggler.el
> @@ -600,7 +600,7 @@ doesn't include leading \"depends\"."
>                  (let ((id (org-element-property :TASK_ID dep)))
>                    (and id
>                         (string-match (concat id " +\\({.*?}\\)") dep-str)
> -                       (org-match-string-no-properties 1))))
> +                       (org-match-string-no-properties 1 dep-str))))
>                 path)
>             ;; Compute number of exclamation marks by looking for the
>             ;; common ancestor between TASK and DEP.
>
> Nicolas, I can push this myself but I haven't pushed to the repo in
> years. What is the current way? Do I just push to master?

I think you should push to maint, so that users of org+contrib package
can benefit from your fix soon enough.  You then need to merge maint
into master.


Regards,

-- 
Nicolas Goaziou