[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Bug: org-babel-ref-parse needs to set current buffer to the buff
Re: [O] Bug: org-babel-ref-parse needs to set current buffer to the buffer of the marker [8.2.2 (release_8.2.2-188-gc57372 @ /home/wvxvw/Projects/org-mode/lisp/)]
Fri, 08 May 2015 10:24:35 +0200
Oleg Sivokon <address@hidden> writes:
> Please let me know if I didn't export the patch properly (patch
Thank you. Some comments follow.
> From fdc1409602b48ba5f4cd1b5be6264d8311b8b11c Mon Sep 17 00:00:00 2001
> From: wvxvw <address@hidden>
> Date: Fri, 8 May 2015 00:14:11 +0300
> Subject: [PATCH] Making sure the buffer pointed by
> org-babel-current-src-block-location is active when moving to the source
The summary line should be shorter. Also you need to add a reference to
the function being modified, e.g.,
* list/ob-ref.el (org-babel-ref-parse): Make sure the buffer pointed by...
Eventually, you need to add "TINYCHANGE" string at the end of the commit
message if you haven't signed FSF papers. See
<http://orgmode.org/worg/org-contribute.html#orgheadline8> for details.
> (goto-char (if (markerp
> - (marker-position
> + (with-current-buffer
> + (marker-buffer
> + (marker-position
> (org-babel-read ref))))
This won't work as `org-babel-read' is not called within the scope of
I think it should be something like this:
(if (markerp org-babel-current-src-block-location)
Bonus points if you can write a test about it in "test-ob.el".