[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

From: Dmitri Makarov
Subject: Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.
Date: Thu, 10 Sep 2015 12:26:34 +0200

Attached is the patch with requested corrections. I hope now this
small patch is sufficiently well commented.



On Thu, Sep 10, 2015 at 11:57 AM, Nicolas Goaziou
<address@hidden> wrote:
> Hello,
> Dmitri Makarov <address@hidden> writes:
>> If you haven't pushed the patch yet, here is attached an updated
>> patch, with a correction in the commit message, and a minor correction
>> in one of the comments.
> Thank you. Some comments follow.
>> > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt <address@hidden> wrote:
>>> LGTM (with a tiny caveat that I can fix: the first line of the commit
>>> message should not end with a dot). Nicolas, can I push this?
> Sure. However, it would be nice to fix the two minor issues below.
>> From: Dmitri Makarov <address@hidden>
>> Date: Wed, 9 Sep 2015 17:24:42 +0200
>> Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat
>> * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab
>>   links to documents open in Adobe Acrobat application.
> You need to mention new functions and variables in the commit message.
>> +(defun as-get-acrobat-page-link ()
> Wrong namespace. It should be prefixed with "org-mac-".
> Regards,
> --
> Nicolas Goaziou

Attachment: patch.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]