[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH v2 0/9] mail, clock and calc changes

From: Aaron Ecay
Subject: Re: [O] [PATCH v2 0/9] mail, clock and calc changes
Date: Wed, 04 Nov 2015 11:36:03 +0000
User-agent: Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/ (x86_64-unknown-linux-gnu)

Hi Jan,

Thanks for the patches!  They look good to me.  I sent a few minor
comments about code style.  I didn’t review the 8th patch (ob-calc: add
more API, documentation and examples so that it can be used in tables)
because I didn’t feel familiar enough with the calc API to be useful.

Do you want somebody to apply the tinychange patches already?  Or do you
want to wait until your assignment is processed and apply them yourself?
(IMO patch 4 could also be a TINYCHANGE, since it is only code movement
with no actual changes).

Aaron Ecay

reply via email to

[Prev in Thread] Current Thread [Next in Thread]