[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] Inconsistency between org-store-link-functions and org-store-link

From: Aaron Ecay
Subject: [O] Inconsistency between org-store-link-functions and org-store-link
Date: Fri, 06 Nov 2015 18:23:13 +0000
User-agent: Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/ (x86_64-unknown-linux-gnu)

Hello all,

The docstring of org-store-link-functions says: “Each function will be
called in turn until one returns a non-nil value.”  However, the code of
org-store-link actually calls all the functions, and if more than one
returns a non-nil value raises a prompt asking the user to choose (and
then calls that function a second time).

Should we change the code to match the doc, or vice versa?


PS I vote for keeping the semantics described in the doc, because the
current implementation’s double calling of the selected function
means that store-link functions that have side effects will behave
unpredictably.  Imagine a store-link function for image buffers that
uploads the buffer to imgur or a similar hosting site, and stores the
http url of the uploaded file.  The current implementation would
upload the image twice.

Aaron Ecay

reply via email to

[Prev in Thread] Current Thread [Next in Thread]