[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-attach.el: Fetch attachments from git annex

From: Erik Hetzner
Subject: Re: [O] [PATCH] org-attach.el: Fetch attachments from git annex
Date: Tue, 05 Jan 2016 17:15:21 -0800
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/25.1.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Thanks for the feedback, Kyle! I will make these changes and resubmit.

And thanks for the pointer to =git annex find PATH=. I think I can use that to
check if a file needs to be fetched.

(more below)

On Mon, 04 Jan 2016 22:21:41 -0800,
Kyle Meyer <address@hidden> wrote:
> Thanks for the patch.
> […]
> > +             (org-attach-use-annex)
> > +             (not (file-exists-p (file-symlink-p path))))
> > +        (call-process "git" nil nil nil "annex" "get" path))
> - Should this display a message before calling "git annex get" to let the
>   user know what's happening in case fetching the file takes some time?

That would make sense. I’ll change it.

> - Should there be a setting the controls whether attachments are
>   automatically fetched?

I don’t see why. If a file is managed in git annex and the user is trying to
open it, I can’t imagine why they wouldn’t want it fetched.

best, Erik
Sent from my free software system <http://fsf.org/>.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]