[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

From: Kyle Meyer
Subject: Re: [O] [PATCH] org-attach.el: Get attachments from git annex
Date: Fri, 29 Jan 2016 00:39:34 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Erik Hetzner <address@hidden> writes:

> I believe this addresses all the issues that have been raised. Thanks for all
> your help with this.

Thanks for the updates.  I just have two minor things to add to Rasmus's

- Nitpick: It'd be nice if you could re-flow some of your lines to not
  be as wide.

- What's the advantage of using cl-defmacro instead of defmacro below?

> +(cl-defmacro test-org-attach-annex/with-annex (&body body)
> +  `(let ((tmpdir (make-temp-file "org-annex-test" t)))
> +     (unwind-protect
> +      (let ((default-directory tmpdir)

Thanks again.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]