[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] expose nrepl's timeout setting in ob-clojure.el

From: Frederick Giasson
Subject: Re: [O] [PATCH] expose nrepl's timeout setting in ob-clojure.el
Date: Mon, 11 Apr 2016 10:03:08 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0

Hi Nicolas,

Some keywords are missing:

   :version "25.1"
   :package-version '(Org . "9.0")

and perhaps

   :safe #'wholenump

Ok good, added.

  (defcustom org-babel-clojure-backend
    (cond ((featurep 'cider) 'cider)
        (t 'slime))
@@ -94,8 +100,9 @@
         (let ((result-params (cdr (assoc :result-params params))))
         (setq result
-               (nrepl-sync-request:eval
-                expanded (cider-current-connection) (cider-current-session))
+               (let ((nrepl-sync-request-timeout 
+                 (nrepl-sync-request:eval
+                  expanded (cider-current-connection) (cider-current-session)))
You forgot to

(defvar nrepl-sync-request-timeout)

This one is defined in the nREPL package. Maybe there is something that I don't understand, but do I have to re-defined it here?

I also think it makes sense to merge the 3 patches.

Ok will do.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]