[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] custom port for postgresql

From: Jakob Lombacher
Subject: Re: [O] [PATCH] custom port for postgresql
Date: Fri, 16 Sep 2016 09:48:45 +0200

Hi Adam,

thanks for the "patch" hint ;-)

I changed the dbport as optional argument and added the dbpassword option as well.


2016-09-14 7:04 GMT+02:00 Adam Porter <address@hidden>:
Jakob Lombacher <address@hidden> writes:

> -(defun org-babel-sql-dbstring-postgresql (host user database)
> +(defun org-babel-sql-dbstring-postgresql (host port user database)

Hi Jakob,

Two suggestions:

1.  Generally people put something like "[PATCH]" in the subject so that
the maintainers will know it contains a patch.  :)

2.  I'd suggest putting the new `port` argument at the end of the
argument list, after an `&optional`.  Even though it makes more sense to
put it after the host, putting it at the end and making it optional
means that people won't have to change existing code that calls this

Thanks for submitting the patch.

Attachment: 0001-add-dbport-and-dbpassword-options-to-psql.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]