[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] custom port for postgresql

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] custom port for postgresql
Date: Sat, 17 Sep 2016 10:39:34 +0200


Jakob Lombacher <address@hidden> writes:

> I changed the dbport as optional argument and added the dbpassword option
> as well.

I applied your patch with the modifications below:

- I added a proper commit message

- I added TINYCHANGE cookie

- I reordered dbport argument as in your initial patch. Although the
  recommendation of making it optional makes sense, it breaks
  consistency with other "dbstring" functions, and this is an internal
  function anyway.

Could you provide an entry for ORG-NEWS file?

Thank you for the patch.


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]