[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorit

From: Renato Ferreira
Subject: [O] [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
Date: Fri, 04 Nov 2016 08:06:00 -0200

When using:
(setq org-agenda-fontify-priorities 'cookies)
(setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
. "#AC7373") (68 . "#7C4343")))

(org-agenda-fontify-priorities) generates an (:inherit nil ...) face
alist, which ultimately (i can't trace specifically where) causes a lot
of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
when generating the agenda buffer (when it contains tasks with

This issue has been present since 8.3 (and earlier i believe), i've
always patched locally but now i'm using melpa so it would be great if
someone could verify and merge this.

Thanks a lot,
Renato Ferreira

org-agenda.el Correct :inherit on org-agenda-fontify-priorities

* Fixes "Invalid face attribute/reference" errors

lisp/org-agenda.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7ee721a..68e82cb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply 
ov 'face
(let ((special-face
(cond ((org-face-from-face-or-color
-                       'priority nil
+                       'priority 'org-priority
(cdr (assoc p org-priority-faces))))
((and (listp org-agenda-fontify-priorities)
-                            'priority nil
+                            'priority 'org-priority
(cdr (assoc p org-agenda-fontify-priorities)))))
((equal p l) 'italic)
((equal p h) 'bold))))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]