[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tag

From: Samuel Loury
Subject: [O] [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tags-todo-only'
Date: Thu, 19 Jan 2017 08:49:42 +0100

Dear all,

I would like to propose a patch for `org-tags-view' to make it stop
setting globally `org--matcher-tags-todo-only'

Setting `org--matcher-tags-todo-only' has side effects on other
commands. For instance, the following clock table changes its behavior
whether `org--matcher-tags-todo-only' is nil or '(4)

--8<---------------cut here---------------start------------->8---
#+BEGIN: clocktable :tags "-perso" :fileskip0 :stepskip0 :link t :maxlevel 5 
:emphasize t :link t :block today-1 :scope agenda :inherit-props t
--8<---------------cut here---------------end--------------->8---

I did not have time to investigate why the behavior of the clock table
is impacted by `org--matcher-tags-todo-only'. I quickly feel lost in
this code.

From c5c763a9aca8cfd8a707b0d7e814bc37f5eeafa1 Mon Sep 17 00:00:00 2001
From: Samuel Loury <address@hidden>
Date: Thu, 19 Jan 2017 08:39:50 +0100
Subject: [PATCH] Make `org-tags-view' stop setting globally

`org--matcher-tags-todo-only' is used at several places in the

The first call of `org-tags-view' that changes its value, like C-u
M-x org-tags-view has the side effect of making all other commands
that don't set this value explicitely rely on this value.

* lisp/org-agenda.el (org-tags-view): Add the declaration of
  `org--matcher-tags-todo-only' in the let form
 lisp/org-agenda.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 737e1841f..ac4bde389 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4681,6 +4681,7 @@ The prefix arg TODO-ONLY limits the search to TODO 
         (completion-ignore-case t)
         rtn rtnall files file pos matcher
+        org--matcher-tags-todo-only
     (when (and (stringp match) (not (string-match "\\S-" match)))
       (setq match nil))

GPG Key    : 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]