[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs |
Date: |
Sun, 25 Jun 2017 09:17:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
Mario Martelli <address@hidden> writes:
>
> Doing the tests for the documentation I encountered some issues with
> org-protocol.
>
> [0001-url-is-sanitized-before-processing]
> I’ve got trouble to get sub-protocol “open-source” working in some cases. By
> sanitising the URL it works for me in all cases.
>
[...]
> This changes the test of the URI which was tested against the resulting
> filename. It’s now tested against the base-url.
>
> I’m still unsure with this because the code is there for more than seven
> years. Maybe I’m not seeing something obvious here. But all tests I made so
> far are succeeding with this change.
>
[...]
If all tests in "test-org-protocol.el" pass with your changes, I think
it is fine to apply them. Another round of tests for the cases you solve
would be nice, too.
Regards,
--
Nicolas Goaziou
- Re: [O] org-protocol documentation, (continued)
- Re: [O] org-protocol documentation, Chunyang Xu, 2017/06/19
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/21
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/21
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/21
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/22
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/22
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/22
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/23
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/23
- [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/25
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs,
Nicolas Goaziou <=
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/25
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/26
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/27
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/28
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Mario Martelli, 2017/06/29
- Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs, Nicolas Goaziou, 2017/06/29
- Re: [O] org-protocol documentation, Mario Martelli, 2017/06/25
- Re: [O] org-protocol documentation, Nicolas Goaziou, 2017/06/29