[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fixed bug in custom timestamps for date ranges.

From: Kaushal Modi
Subject: Re: [O] [PATCH] Fixed bug in custom timestamps for date ranges.
Date: Thu, 06 Jul 2017 12:58:31 +0000

Hi Jan,

I haven't reviewed the patch functionality, but I see that it is missing a commit message. Please review this to learn about the required format for commit messages:



On Thu, Jul 6, 2017, 5:10 AM Jan Seeger <address@hidden> wrote:
Changed org-activate-dates to activate custom timestamps for both
dates in date ranges. Formerly, only the second date would be
activated. The reason was a misplaced "if". Replaced it with "when".
 lisp/org.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index ab0bde1ef..f000c8f24 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -6105,9 +6105,11 @@ by a #."
                               'keymap org-mouse-map))
     (org-rear-nonsticky-at (match-end 0))
     (when org-display-custom-times
-      (if (match-end 3)
-         (org-display-custom-time (match-beginning 3) (match-end 3))
-       (org-display-custom-time (match-beginning 1) (match-end 1))))
+      ;; If it's a date range, activate custom time for second date
+      (when (match-end 3)
+       (org-display-custom-time (match-beginning 3) (match-end 3)))
+      ;; Always  activate custom time for first matched date
+      (org-display-custom-time (match-beginning 1) (match-end 1)))

 (defvar-local org-target-link-regexp nil

Kaushal Modi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]