[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Refactor org-set-tags arguments for clarity

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 13:58:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Kaushal Modi <address@hidden> writes:

> I was itching to do that. But there are dozens of (org-set-tags nil t)

Calls in code base do not matter, since we can change them. The above
Sexp would be equivalent to 

  (org-set-tags 'current)

> instances in the Org source itself. I though just created a wrapper in my
> personal config to do ALIGN-ONLY-CURRENT when prefix is C-u C-u.

I don't think an user needs to distinguish between aligning all and
aligning only current. I think this is just confusing.

> PS: Also, in addition, was thinking of calling JUST-ALIGN ALIGN-ALL
> instead.

Sounds good.

> With:
>     (defun org-set-tags (&optional ALIGN-ALL ALIGN-ONLY-CURRENT) ..
> it will be more apparent that they are mutually exclusive args.

It still bugs me because (org-set-tags t t) doesn't make any sense.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]