emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel
Date: Wed, 02 Aug 2017 00:03:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hello,

Christian Garbs <address@hidden> writes:

> Hello and sorry for the wait!

No problem.

> Looking at the other defcustoms, is the current wording ok?

It is.

> Some of your proposed changes apply to ob-C.el as well.  I could
> prepare a different patch for that (under which topic?),

Depending on the size of the changes, it could be "Tiny changes", "Small
refactoring"...

> but I am not confident that I could test the changes appropriately.
> I don't have proper C/C++/D org files handy that would cover all cases
> (eg. header arguments).

ob-C.el has a couple of tests (BTW, would you want to write some for
"ob-vala.el"?).

> PS: My FSF paperwork is complete.

I overlooked this information. These are great news. I'll push your
patch once updated (see my other mail).

Could you provide an ORG-NEWS entry about the new file?

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]