[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-columns-summary-types entries can take COLLECT funct
Re: [O] [PATCH] org-columns-summary-types entries can take COLLECT function
Sun, 10 Sep 2017 11:21:39 +0200
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
Stig Brautaset <address@hidden> writes:
> I've taken a stab at adding support for allowing
> org-columns-summary-types entries to contain an optional COLLECT
> function that can be used to conditionally collect a property.
> Please see the included patch. I added a NEWS entry, but wasn't sure
> whether a manual entry is required.
I don't think so. Usage is quite advanced, and there's already a pointer
to the docstring.
> I added a couple simple tests, which pass, but the test immediately
> above the two I added fails when this patch is applied; I haven't been
> able to figure out why. Any help appreciated.
I fixed that. I also inserted two spaces at the end of sentences in the
> Subject: [PATCH] org-colview: Allow custom COLLECT functions for derived
> In addition to (LABEL . SUMMARIZE), org-columns-summary-types now
> accepts (LABEL SUMMARIZE COLLECT) entries. The new COLLECT function is
> called with one argument, the property being summarized.
I fixed the commit message (missing references to modified functions).
I added "TINYCHANGE" at the end of the commit.
I applied the patch.
>From now on, please consider signing FSF papers if you want to provide