[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] S5 HTML export - org9.1.1

From: Kyle Meyer
Subject: Re: [O] S5 HTML export - org9.1.1
Date: Sat, 07 Oct 2017 14:51:05 -0400

address@hidden writes:

> I have evaluated the following function found in ox-html.el
> and indeed the S5 html works when this function is defined.
> (defun org-html-end-plain-list (type)
>   "Insert the end of the HTML list depending on TYPE."
>   (case type
>     (`ordered "</ol>")
>     (`unordered "</ul>")
>     (`descriptive "</dl>")))

Yes, that's the function that was removed in 8855c23c6.

> I don't know if this function should appear accordly in
> ox-S5.el or elsewhere. As I don't use development environment
> I don't know how a patch has to be submitted.
> Anyway thank for your help. Hope it can be useful for the
> person who knows how to implement it and where.

I don't use ox-s5.el, but the I think the below fix should do.  I'll
push it in a few days if no one objects.

-- >8 --
Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list

* contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of

The function org-html-end-plain-list was deleted in
8855c23c6 (ox-html: Plain list supports arbitrary attributes,

Reported-by: <address@hidden>
 contrib/lisp/ox-s5.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el
index 8f9501058..0496aae19 100644
--- a/contrib/lisp/ox-s5.el
+++ b/contrib/lisp/ox-s5.el
@@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info)
              "<%s class='org-%s%s'>" tag tag
              (if (org-export-get-node-property :INCREMENTAL plain-list t)
                  " incremental" ""))
-            contents (org-html-end-plain-list type))))
+            contents
+           (format "</%s>" tag))))
 (defun org-s5-inner-template (contents info)
   "Return body of document string after HTML conversion.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]